Codecov Report

Attention: Patch coverage is 97.95918% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.53%. Comparing base (4275f06) to head (f50c391).
Report is 2 commits behind head on main.

@@           Coverage Diff           @@
##             main   #14269   +/-   ##
=======================================
  Coverage   95.53%   95.53%           
=======================================
  Files        1859     1859           
  Lines       24076    24091   +15     
  Branches     2777     2779    +2     
=======================================
+ Hits        23001    23016   +15     
  Misses        817      817           
  Partials      258      258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Testing

Studio crashed when uploading this code list in Gitea:

[
  {
    "label": "Yes",
    "value": "yes",
    "invalidProperty": true
  }
]

With the following error:

optionListsData.map is not a function
convertOptionsListsDataToCodeListsData
...

The error still occurs when:

• Deleting all code lists from repo in Gitea
• Uploading a valid code list to Gitea

Are you able to reproduce this? This was tested in localhost.

Testing

Studio crashed when uploading this code list in Gitea:

[
  {
    "label": "Yes",
    "value": "yes",
    "invalidProperty": true
  }
]

With the following error:

optionListsData.map is not a function
convertOptionsListsDataToCodeListsData
...

The error still occurs when:

• Deleting all code lists from repo in Gitea
• Uploading a valid code list to Gitea

Are you able to reproduce this? This was tested in localhost.

Hm, I tested locally now, and I am not able to reproduce it 🤔 It actually looks like the backend does not care about additional properties so I do not get any error at all. The error occurs if trying to set an object e.g. as the value for the value-key.

But I did try setting the label-value to an object and removing the label-field; both results in 500 in backend, which is not suppose to happen. But I guess that is issue that exists from before. On the other hand, this PR might be the correct place to fix it tho 🤷

Hm, I tested locally now, and I am not able to reproduce it 🤔 It actually looks like the backend does not care about additional properties so I do not get any error at all. The error occurs if trying to set an object e.g. as the value for the value-key.

But I did try setting the label-value to an object and removing the label-field; both results in 500 in backend, which is not suppose to happen. But I guess that is issue that exists from before. On the other hand, this PR might be the correct place to fix it tho 🤷

I tried restarting the local dev servers, and that seemed to fix it. My bad.
It works now:

I also noticed that trailing commas in the JSON file resulted in a 500 error, which caused the frontend error optionListsData.map is not a function to appear. Maybe I was experiencing a 500 error earlier today, and that caused the frontend to act up.

I think we should collect the 500 errors in a different issue, since it's not part of your scope 😊

Edit: see new issue here - #14351